perplexity: give more information about constraints on failure #15303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checks whether -np is insufficient vs context, and provides clues as to how much is needed for each.
ggerganov
reviewed
Aug 14, 2025
tools/perplexity/perplexity.cpp
Outdated
|
|
||
| int num_answers = cur_task.seq_tokens.size(); | ||
| if (s0 + num_answers > max_seq) { | ||
| max_seq_exceeded = s0 + num_answers; |
Member
There was a problem hiding this comment.
We can log the error here and straight up return. This way no need to declare max_seq_exceeded var
Contributor
Author
There was a problem hiding this comment.
I guess I should check s0 == 0 instead of i0 == i1. Edit: switched to doing that.
ggerganov
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks whether -np is insufficient vs context, and provides clues as to how much is needed for each.
The current error message is incorrectly blaming insufficient context e.g. for TruthfulQA which requires -np=16 or so due to
num_answersbeing near that value.