docker : add cann build pipline #14591
Merged
+133
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
devops
github-actions
bot
added
ggml
ngxson
approved these changes
Jul 16, 2025
There was a problem hiding this comment.
I don't have time to test this, but the code looks OK
Also cc @ggerganov if you want to have a look
Co-authored-by: Xuan-Son Nguyen <[email protected]>
|
Thank you for your contribution. Please fix CI failures. |
hipudding
reviewed
Aug 1, 2025
| @@ -1911,6 +1911,9 @@ static bool ggml_backend_cann_cpy_tensor_async( | |||
| (ggml_backend_cann_context*)backend_dst->context; | |||
|
|
|||
| size_t copy_size = ggml_nbytes(dst); | |||
| if (copy_size == 0) { | |||
There was a problem hiding this comment.
Just curious, could there be a scenario where copy_size is 0?
hipudding
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request significantly enhances the build process for
llama.cppwith Huawei's CANN backend.