webui : use fflate for more deterministic gzip compress #13525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngxson
changed the title
|
It should be ok now, I switched from |
ggerganov
approved these changes
May 14, 2025
Silver267
pushed a commit
to Silver267/llama.cpp
that referenced
this pull request
May 14, 2025
* webui : use pako for more deterministic gzip compress * simpler code * use fflate instead of pako
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build sometimes produce nondeterministic result on older nodejs version, or on windows. The main reason is because the built-in
zlibversion ofnodeis not always the same.This PR replaces
node:zlibwith fflate for gzip compression. It is a pure JS implementation, not relying onzlib, so the build is now deterministic.