-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Fix potential licensing issue #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
remove facebook
This is a complete reimplementation of the GPL code. I don't think GPL applies in this case. |
https://www.gnu.org/licenses/old-licenses/gpl-2.0.html
@sowa705 you sure? what does facebook use? or is this changed enough not to be considered a translation? |
There is no derivative work here. Its a completely different program that happens to implement the same algorithm (in a different way) |
@sowa705 Thats exactly what I wanted to clarify by this PR. I suggest changing the language that can imply this repo is a derivative work. |
@@ -3,7 +3,7 @@ | |||
[](https://github.com/ggerganov/llama.cpp/actions) | |||
[](https://opensource.org/licenses/MIT) | |||
|
|||
Inference of [Facebook's LLaMA](https://github.com/facebookresearch/llama) model in pure C/C++ | |||
Inference of [LLaMA](https://arxiv.org/abs/2302.13971) model in pure C/C++ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inference of [LLaMA](https://arxiv.org/abs/2302.13971) model in pure C/C++ | |
Inference of [Facebook's LLaMA](https://arxiv.org/abs/2302.13971) model in pure C/C++ |
* Update README.md * Update README.md remove facebook
* Update README.md * Update README.md remove facebook
What about using the model? How can you be sure it's not against their terms? @musabgultekin @sowa705 |
I have no idea about that |
Center align cute llama image in README
Deprecate example server
I'm not an expert on Licenses BUT,
If you attribute Facebook in the README and description, you essentially admit/imply that this repo is a modification of their repo. Facebook's repo has "GPL-3.0 license". Which means this repo should also be like that in that case, which is something that we dont want.
This PR fixing that potential language issue.
Also recommend changing the description too. Such as
"Port of LLaMA model in C/C++"