Skip to content

Missing new lines in server_print_usage in server.cpp #5785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nelsonhurstdev opened this issue Feb 28, 2024 · 0 comments
Closed

Missing new lines in server_print_usage in server.cpp #5785

nelsonhurstdev opened this issue Feb 28, 2024 · 0 comments

Comments

@nelsonhurstdev
Copy link

In server.cpp in the server_print_usage method, newlines are missing at the end of the -gan N and-gaw N print strings.

Currently:

printf("  -gan N, --grp-attn-n N    set the group attention factor to extend context size through self-extend(default: 1=disabled), used together with group attention width `--grp-attn-w`");
printf("  -gaw N, --grp-attn-w N    set the group attention width to extend context size through self-extend(default: 512), used together with group attention factor `--grp-attn-n`");

Expected :

printf("  -gan N, --grp-attn-n N    set the group attention factor to extend context size through self-extend(default: 1=disabled), used together with group attention width `--grp-attn-w`\n");
printf("  -gaw N, --grp-attn-w N    set the group attention width to extend context size through self-extend(default: 512), used together with group attention factor `--grp-attn-n`\n");

Seems like an easy PR for someone trying to get experience.

hazelnutcloud pushed a commit to hazelnutcloud/llama.cpp that referenced this issue Mar 10, 2024
jordankanter pushed a commit to jordankanter/llama.cpp that referenced this issue Mar 13, 2024
hodlen pushed a commit to hodlen/llama.cpp that referenced this issue Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants