Skip to content

Feature Request: Alternate Interrupt method in instruct mode #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CRD716 opened this issue Apr 23, 2023 · 3 comments
Closed

Feature Request: Alternate Interrupt method in instruct mode #1135

CRD716 opened this issue Apr 23, 2023 · 3 comments
Labels
enhancement New feature or request stale

Comments

@CRD716
Copy link
Contributor

CRD716 commented Apr 23, 2023

It would be nice to have a way to interrupt the model's output and inject your own words into the response, instead of starting a new instruction. This could be useful for writers, as well as generally just being cool.

@sw
Copy link
Contributor

sw commented Apr 23, 2023

Maybe somewhat related to --author-mode proposed in #1040, at least in terms of intended user group.

@sw sw added the enhancement New feature or request label Apr 23, 2023
@DannyDaemonic
Copy link
Contributor

@CRD716 Are you talking about instruct mode here? If so, a clearer title might have been: "Feature Request: Alternate Interrupt method in instruct mode"

Assuming we're talking about instruct mode, I wonder if that feature is a good fit with --author-mode. It shouldn't be too hard to integrate that into it but it's a different codewise.

We'd have to store a state somewhere that said if instruction mode was interrupted by Ctrl+C so we'd know not to resume inference from wherever we were instead of starting a new "### Instruction:". Author mode would certainly help in resuming on the same line, but other than that, it's more about how the console interprets lines, not how it handles resets.

It could also be a different option that may be implied by --author-mode? Something like --instruct-interactive? I think the biggest downside to adding switches is that --help may get overwhelming. I do plan on making a pull request that separates the common options from the advanced options so this isn't as big of an issue.

Alternatively, as it currently is, when you Ctrl+C in instruct mode, perhaps people would just prefer if it always allowed them to interject on the answer?

@CRD716 CRD716 changed the title Feature Request: Alternate Interupt method in interactive mode Feature Request: Alternate Interrupt method in instruct mode Apr 23, 2023
@github-actions github-actions bot added the stale label Mar 25, 2024
Copy link
Contributor

github-actions bot commented Apr 9, 2024

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

3 participants