Allow timeouting on poll #8282
Merged
Allow timeouting on poll #8282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
approved these changes
Sep 30, 2025
emilk
reviewed
Oct 1, 2025
| timeout: Option<Duration>, | ||
| ) -> Result<bool, crate::DeviceError> { | ||
| let timeout_duration = Duration::from_millis(timeout_ms as u64); | ||
| let timeout = timeout.unwrap_or(Duration::MAX); |
There was a problem hiding this comment.
If None means the same as Duration::MAX, why pass duration by Option at all?
From just the function declaration it is far from obvious that None means MAX. It could just as well mean "Use the default timeout"
There was a problem hiding this comment.
none of the implementations do this right now, but often there's simpler fast/path for no timeout. I think for the low-level hal api this is fine like that, but I am missing docstring on the trait this implements
This was referenced Oct 1, 2025
sharmajai
pushed a commit
to sharmajai/wgpu
that referenced
this pull request
Oct 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
Introduces
wgpu::PollType::WaitWithTimeout/wgpu::PollType::WaitForSubmissionIndexWithTimeoutvariants to allow specifying a timeout on polls. This is useful for instance for image comparision tests or similar in a CI environment!Decided to expose this as new enum variants since this is the least intrusive for current code and least bothersome if one doesn't care about timeouts here.
Went with
Durationall the way since it's most expressive and doesn't require unit documentation/assumptions.A soft-breaking change that comes along with this is that the non-timeout waits no longer have a hardcoded timeout of 60s. Note that the constant that set this was misdocumented at this point: our timeouting on device drop is a lot more sophisticated by now and there's no more UB involved in any of this!
Testing
Added test, some coverage by existing
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.