Skip to content

Fix webgl srgb blit not setting the viewport correctly #3093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2022
Merged

Fix webgl srgb blit not setting the viewport correctly #3093

merged 2 commits into from
Oct 11, 2022

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Oct 11, 2022 •
edited
Loading

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Description
Srgb conversion on webgl assumed the viewport was correctly set. But what if it isn't? This can happen:
image

Testing
manual testing with an egui application

This was referenced Oct 11, 2022
Open
Merged
cwfitzgerald
cwfitzgerald approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh

cwfitzgerald
cwfitzgerald reviewed Oct 11, 2022
View reviewed changes
@cwfitzgerald cwfitzgerald merged commit 351ca3e into gfx-rs:master Oct 11, 2022
@Wumpf Wumpf deleted the webgl/fix-srgb-path-viewport-dependency branch October 11, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Wumpf @cwfitzgerald