Skip to content

Conversation

paul-paliychuk
Copy link
Contributor

@paul-paliychuk paul-paliychuk commented Jul 15, 2024

🚀 This description was created by Ellipsis for commit b157c70

Summary:

Added fact rating functionality and related methods to MemoryClient and AsyncMemoryClient, updated to version 1.0.7, and modified example script.

Key points:

  • Updated pyproject.toml to version 1.0.7.
  • Added new types: FactRatingExamples, FactRatingInstruction, FactResponse, FactsResponse in src/zep_cloud/types.
  • Updated src/zep_cloud/__init__.py to include new types in imports and __all__.
  • Updated src/zep_cloud/core/client_wrapper.py to reflect version 1.0.7.
  • Added methods get_fact, delete_fact, get_session_facts to MemoryClient and AsyncMemoryClient in src/zep_cloud/memory/client.py.
  • Added fact_rating_instruction parameter to add_session, update_session methods in MemoryClient and AsyncMemoryClient.
  • Added min_fact_rating parameter to search_sessions and search methods in MemoryClient and AsyncMemoryClient.
  • Updated Fact model in src/zep_cloud/types/fact.py to include rating field.
  • Modified examples/chat_history/memory.py to reduce sleep time from 65 to 5 seconds.

Generated with ❤️ by ellipsis.dev

@paul-paliychuk paul-paliychuk marked this pull request as ready for review July 15, 2024 18:31
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to a1b05c6 in 49 seconds

More details
  • Looked at 884 lines of code in 11 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_6Obxek2OZsPELcyn


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on b7ac992 in 37 seconds

More details
  • Looked at 49 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_DsyDgjwbcZAJ5b2A


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on b157c70 in 46 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. examples/chat_history/memory.py:75
  • Draft comment:
    Reducing the sleep duration from 65 seconds to 5 seconds might cause issues if the messages are not fully processed within this shorter time frame. Consider reverting this change or ensuring that the new duration is sufficient for message processing.
    await asyncio.sleep(65)
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_GQSFyYyCt0ZgZN27


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@paul-paliychuk paul-paliychuk merged commit c4b72d1 into main Jul 18, 2024
@paul-paliychuk paul-paliychuk deleted the v2 branch July 18, 2024 17:02
@paul-paliychuk paul-paliychuk restored the v2 branch July 22, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant