-
Notifications
You must be signed in to change notification settings - Fork 22
v1.0.7 #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0.7 #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to a1b05c6 in 49 seconds
More details
- Looked at
884
lines of code in11
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_6Obxek2OZsPELcyn
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Incremental review on b7ac992 in 37 seconds
More details
- Looked at
49
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_DsyDgjwbcZAJ5b2A
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on b157c70 in 46 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. examples/chat_history/memory.py:75
- Draft comment:
Reducing the sleep duration from 65 seconds to 5 seconds might cause issues if the messages are not fully processed within this shorter time frame. Consider reverting this change or ensuring that the new duration is sufficient for message processing.
await asyncio.sleep(65)
- Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_GQSFyYyCt0ZgZN27
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Summary:
Added fact rating functionality and related methods to
MemoryClient
andAsyncMemoryClient
, updated to version1.0.7
, and modified example script.Key points:
pyproject.toml
to version1.0.7
.FactRatingExamples
,FactRatingInstruction
,FactResponse
,FactsResponse
insrc/zep_cloud/types
.src/zep_cloud/__init__.py
to include new types in imports and__all__
.src/zep_cloud/core/client_wrapper.py
to reflect version1.0.7
.get_fact
,delete_fact
,get_session_facts
toMemoryClient
andAsyncMemoryClient
insrc/zep_cloud/memory/client.py
.fact_rating_instruction
parameter toadd_session
,update_session
methods inMemoryClient
andAsyncMemoryClient
.min_fact_rating
parameter tosearch_sessions
andsearch
methods inMemoryClient
andAsyncMemoryClient
.Fact
model insrc/zep_cloud/types/fact.py
to includerating
field.examples/chat_history/memory.py
to reduce sleep time from 65 to 5 seconds.Generated with ❤️ by ellipsis.dev