Skip to content

feat(ui2): chonky inputs #95771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2025
Merged

feat(ui2): chonky inputs #95771

merged 3 commits into from
Jul 21, 2025

Conversation

TkDodo
Copy link
Contributor

@TkDodo TkDodo commented Jul 17, 2025

Add chonk to input, select, multi-select and textArea

Screenshot 2025-07-17 at 14 03 08 Screenshot 2025-07-17 at 14 03 36 Screenshot 2025-07-17 at 14 03 59 Screenshot 2025-07-17 at 14 04 22 Screenshot 2025-07-17 at 14 04 48

Copy link

linear bot commented Jul 17, 2025

@TkDodo TkDodo marked this pull request as ready for review July 17, 2025 12:27
@TkDodo TkDodo requested review from a team as code owners July 17, 2025 12:27
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 17, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Absolute Positioning Disrupts Suffix Alignment

Adding position: absolute to the Suffix component breaks its horizontal alignment. The original design used a HiddenValue span (with visibility: hidden) to create horizontal space, positioning the Suffix immediately after the input text. With position: absolute, Suffix is removed from the normal document flow, ignoring the HiddenValue's spacing and making its margin-left ineffective. This causes the Suffix to appear in the wrong horizontal position, potentially overlapping the input value or appearing at the left edge of its container.

static/app/components/forms/fields/numberField.tsx#L108-L111

margin-left: ${space(0.5)};
position: absolute;
top: 50%;
transform: translateY(-50%);

Fix in CursorFix in Web


Bug: CSS Template Literal Interpolation Error

The boxShadow CSS property was incorrectly defined using single quotes instead of backticks for template literals, specifically affecting variables like chonk and theme.tokens.border.primary. This prevented proper variable interpolation, causing the literal variable names to appear in the CSS string instead of their intended values.

static/app/components/core/input/index.chonk.tsx#L15-L16

background: theme.tokens.background.secondary,
boxShadow: `0px 2px 0px 0px ${theme.tokens.border.primary} inset`,

static/app/components/core/select/index.chonk.tsx#L70-L71

border: `1px solid ${theme.border}`,
boxShadow: `0px ${chonk} 0px 0px ${theme.tokens.border.primary} inset`,

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

@TkDodo TkDodo requested a review from Jesse-Box July 21, 2025 08:25
@TkDodo TkDodo merged commit 9194d74 into master Jul 21, 2025
47 checks passed
@TkDodo TkDodo deleted the tkdodo/feat/de-68-chonky-inputs branch July 21, 2025 13:32
andrewshie-sentry pushed a commit that referenced this pull request Jul 21, 2025
Add chonk to input, select, multi-select and textArea

<img width="1266" height="614" alt="Screenshot 2025-07-17 at 14 03 08"
src="https://github.com/user-attachments/assets/6515dab6-123b-4f35-b645-5c07190b7718"
/>
<img width="1503" height="464" alt="Screenshot 2025-07-17 at 14 03 36"
src="https://github.com/user-attachments/assets/38ddb89e-fe28-4f59-8c2c-740d19e5afed"
/>
<img width="1503" height="382" alt="Screenshot 2025-07-17 at 14 03 59"
src="https://github.com/user-attachments/assets/36c5b0a7-ddeb-4736-ac67-9b64de8290df"
/>
<img width="1329" height="355" alt="Screenshot 2025-07-17 at 14 04 22"
src="https://github.com/user-attachments/assets/f28d7d3a-7334-49cb-a59f-2b60250ba88b"
/>
<img width="1419" height="432" alt="Screenshot 2025-07-17 at 14 04 48"
src="https://github.com/user-attachments/assets/9764e199-3da9-4e5f-8ac7-280738dd0165"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants