-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(seer-prefs): repo cleanup for org deleted repos #95768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #95768 +/- ##
===========================================
+ Coverage 38.57% 87.78% +49.21%
===========================================
Files 9966 10577 +611
Lines 559498 610100 +50602
Branches 23972 23844 -128
===========================================
+ Hits 215806 535560 +319754
+ Misses 343408 74246 -269162
- Partials 284 294 +10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Seer API Provider Format Inconsistency
The cleanup_seer_repository_preferences
task sends repo.provider
to the Seer API. However, the repo.provider
field can be inconsistently formatted: it may include an "integrations:" prefix (e.g., "integrations:github") when the repository is linked via an integration, while other cases might use just the provider name (e.g., "github"). This inconsistency can cause issues if Seer expects a uniform provider format.
src/sentry/integrations/api/endpoints/organization_repository_details.py#L100-L108
sentry/src/sentry/integrations/api/endpoints/organization_repository_details.py
Lines 100 to 108 in e69d54b
if repo.external_id and repo.provider: | |
cleanup_seer_repository_preferences.apply_async( | |
kwargs={ | |
"organization_id": repo.organization_id, | |
"repo_external_id": repo.external_id, | |
"repo_provider": repo.provider, | |
} | |
) |
Was this report helpful? Give feedback by reacting with 👍 or 👎
When you delete a repo from the UI (the `PUT` endpoint) we'll delete it from seer preferences as well. Tested locally with sentry <-> seer
When you delete a repo from the UI (the `PUT` endpoint) we'll delete it from seer preferences as well. Tested locally with sentry <-> seer
When you delete a repo from the UI (the
PUT
endpoint) we'll delete it from seer preferences as well.Tested locally with sentry <-> seer