Skip to content

fix(ui2): reduces button cholnk #95767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2025
Merged

fix(ui2): reduces button cholnk #95767

merged 3 commits into from
Jul 21, 2025

Conversation

TkDodo
Copy link
Contributor

@TkDodo TkDodo commented Jul 17, 2025

  • hover chonk was reduced from +2px to +1px
  • regular chonk for md was reduced from 3px to 2px

final chonk values are:

size chonk hover
md 2px 3px
sm 2px 3px
xs 1px 2px
zero 0px 1px

regular state:

before after
Screenshot 2025-07-17 at 12 13 48 Screenshot 2025-07-17 at 12 15 12

hover state:

before after
Screenshot 2025-07-17 at 12 14 38 Screenshot 2025-07-17 at 12 15 29

@TkDodo TkDodo marked this pull request as ready for review July 17, 2025 10:18
@TkDodo TkDodo requested a review from a team as a code owner July 17, 2025 10:18
@TkDodo TkDodo requested a review from Jesse-Box July 17, 2025 10:19
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 17, 2025
@TkDodo TkDodo merged commit aaed865 into master Jul 21, 2025
47 checks passed
@TkDodo TkDodo deleted the tkdodo/fix/reduce-button-chonk branch July 21, 2025 11:59
andrewshie-sentry pushed a commit that referenced this pull request Jul 21, 2025
- hover chonk was reduced from +2px to +1px
- regular chonk for `md` was reduced from 3px to 2px

final chonk values are:

| size | chonk | hover |
|--------|--------|--------|
| md | 2px | 3px |
| sm | 2px | 3px |
| xs | 1px | 2px |
| zero | 0px | 1px | 

regular state:

| before | after |
|--------|--------|
| <img width="1167" height="253" alt="Screenshot 2025-07-17 at 12 13 48"
src="https://github.com/user-attachments/assets/d425831c-7cb7-4f25-85f0-62a9bfa11feb"
/> | <img width="1167" height="253" alt="Screenshot 2025-07-17 at 12 15
12"
src="https://github.com/user-attachments/assets/d4d8a246-7c1f-4991-9b94-a145d98e8cd3"
/> |

hover state:

| before | after |
|--------|--------|
| <img width="1167" height="253" alt="Screenshot 2025-07-17 at 12 14 38"
src="https://github.com/user-attachments/assets/07da3d10-b6fa-47df-907c-48355e7b82f6"
/> | <img width="1167" height="253" alt="Screenshot 2025-07-17 at 12 15
29"
src="https://github.com/user-attachments/assets/537d6e28-cec3-4bf9-b606-c74f34528d60"
/> |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants