Skip to content

perf(replays): prefetch ai summary data in ReplayDetailsProviders #95761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Jul 17, 2025

@aliu39 aliu39 requested a review from a team as a code owner July 17, 2025 07:50
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 17, 2025
Copy link

linear bot commented Jul 17, 2025

cursor[bot]

This comment was marked as outdated.

@@ -604,6 +614,7 @@ export function Provider({
<ReplayCurrentTimeContextProvider>
<ReplayPlayerContext
value={{
replaySummary: {apiQueryResult: replaySummaryQueryResult},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why wrap the result in apiQueryResult?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case we want to extend this context with other fields later

@aliu39 aliu39 requested a review from billyvg July 17, 2025 20:57
@billyvg billyvg removed their request for review July 18, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants