Skip to content

ref(flags): add generic provider onboarding #82387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 7, 2025
Merged

ref(flags): add generic provider onboarding #82387

merged 7 commits into from
Jan 7, 2025

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented Dec 19, 2024 •
edited
Loading

settings page

now we have a 'generic' option in the dropdown:
SCR-20250107-jves
SCR-20250107-jvhn

python onboarding

SCR-20250107-jvqt

js onboarding

SCR-20250107-jvxt

closes https://github.com/getsentry/team-replay/issues/518

@michellewzhang michellewzhang requested review from a team as code owners December 19, 2024 18:58
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 19, 2024
@cmanallen
Copy link
Member

@michellewzhang I'm writing docs for the generic web hook setup. Can we wait to merge until we can link that docs page?

@michellewzhang
Copy link
Member Author

michellewzhang commented Dec 19, 2024 •
edited
Loading

@michellewzhang I'm writing docs for the generic web hook setup. Can we wait to merge until we can link that docs page?

yup, i can wait! where in the onboarding did you want to add a link?

@cmanallen
Copy link
Member

@michellewzhang In this section:
Screenshot 2024-12-19 at 1 42 20 PM

This text will need to be reworked for custom providers since we can't link to their web hook registration page. We'll link to our docs and they can figure it out on their end.

@michellewzhang
Copy link
Member Author

@michellewzhang In this section: Screenshot 2024-12-19 at 1 42 20 PM

This text will need to be reworked for custom providers since we can't link to their web hook registration page. We'll link to our docs and they can figure it out on their end.

oh gotcha, yeah makes sense. for now i just disabled the link - you can see in this screenshot
image

michellewzhang
michellewzhang commented Jan 2, 2025
View reviewed changes
@michellewzhang michellewzhang mentioned this pull request Jan 2, 2025
Merged
@michellewzhang michellewzhang marked this pull request as draft January 2, 2025 22:11
michellewzhang
michellewzhang commented Jan 3, 2025
View reviewed changes
@michellewzhang michellewzhang marked this pull request as ready for review January 7, 2025 18:24
cmanallen
cmanallen approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@cmanallen cmanallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shiould rename "Custom" to "Self-Serve" to match the docs.

@cmanallen
Copy link
Member

@michellewzhang Open to disagreement on whether custom or self-serve is more appropriate 😅

@michellewzhang
Copy link
Member Author

@michellewzhang Open to disagreement on whether custom or self-serve is more appropriate 😅

is the endpoint still generic? i feel like having 3 different namings here ('self-serve', 'custom', & 'generic') is not the best idea. we should consolidate down to one name

@cmanallen
Copy link
Member

@michellewzhang Okay we should probably rename to Generic then in the docs.

@michellewzhang
Copy link
Member Author

@michellewzhang Okay we should probably rename to Generic then in the docs.

cool, i have a pr out that can do this: getsentry/sentry-docs#12270

@michellewzhang
Copy link
Member Author

@michellewzhang Okay we should probably rename to Generic then in the docs.

cool, i have a pr out that can do this: getsentry/sentry-docs#12270

@cmanallen updated labels to be "generic" everywhere

michellewzhang
michellewzhang commented Jan 7, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Jan 7, 2025

Bundle Report

Changes will increase total bundle size by 129.44kB (0.4%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
app-webpack-bundle-array-push 32.2MB 129.44kB (0.4%) ⬆️

@michellewzhang michellewzhang merged commit e080c66 into master Jan 7, 2025
43 checks passed
@michellewzhang michellewzhang deleted the mz/add-generic-onboarding branch January 7, 2025 20:07
michellewzhang added a commit that referenced this pull request Jan 15, 2025
@michellewzhang @aliu39
feat(flags): add unleash to provider dropdowns and onboarding (#82836)
383c5d7 
branched off of #82387
closes getsentry/team-replay#515
closes getsentry/team-replay#530

### settings page
<img width="995" alt="SCR-20250102-mncr"
src="https://github.com/user-attachments/assets/6404d15c-94da-41e1-8c13-5215bf2c5b66"
/>
<img width="997" alt="SCR-20250102-mnew"
src="https://github.com/user-attachments/assets/e15f10df-ba01-48ed-9f29-75db4fc745ef"
/>


### onboarding dropdowns
<img width="450" alt="SCR-20250102-mnbf"
src="https://github.com/user-attachments/assets/b9a733e4-dc98-4217-baca-9d1ed95d8980"
/>
<img width="435" alt="SCR-20250102-mnag"
src="https://github.com/user-attachments/assets/f05a781f-752a-4f4c-a4d3-af217773c6a3"
/>

### python onboarding
<img width="467" alt="SCR-20250107-jlgk"
src="https://github.com/user-attachments/assets/978a31ff-3929-480f-ae24-2d2cc48c17f8"
/>


### js onboarding
<img width="472" alt="SCR-20250114-jlyw"
src="https://github.com/user-attachments/assets/0c43d47d-15fe-4d3e-ae8d-85cf8afe3f12"
/>

### also updated generic python onboarding:
<img width="477" alt="SCR-20250114-kyvf"
src="https://github.com/user-attachments/assets/99aa6824-9e27-4b9f-96cc-3e548c5c8852"
/>

---------

Co-authored-by: Andrew Liu <[email protected]>
andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
@michellewzhang @andrewshie-sentry
ref(flags): add generic provider onboarding (#82387)
d1894a0 
### settings page 

now we have a 'generic' option in the dropdown:
<img width="966" alt="SCR-20250107-jves"
src="https://github.com/user-attachments/assets/33831a63-652d-4fef-8f73-71c81ea7bbc9"
/>
<img width="985" alt="SCR-20250107-jvhn"
src="https://github.com/user-attachments/assets/139ded9b-4408-412a-a374-1b49232f0093"
/>



### python onboarding 

<img width="470" alt="SCR-20250107-jvqt"
src="https://github.com/user-attachments/assets/e8967cfd-aa69-4108-8f46-61d20f33a5ac"
/>

### js onboarding

<img width="465" alt="SCR-20250107-jvxt"
src="https://github.com/user-attachments/assets/d31925c0-4ff4-4069-876b-f63652351c6a"
/>


closes getsentry/team-replay#518
andrewshie-sentry pushed a commit that referenced this pull request Jan 22, 2025
@michellewzhang @aliu39 @andrewshie-sentry
feat(flags): add unleash to provider dropdowns and onboarding (#82836)
2e2e004 
branched off of #82387
closes getsentry/team-replay#515
closes getsentry/team-replay#530

### settings page
<img width="995" alt="SCR-20250102-mncr"
src="https://github.com/user-attachments/assets/6404d15c-94da-41e1-8c13-5215bf2c5b66"
/>
<img width="997" alt="SCR-20250102-mnew"
src="https://github.com/user-attachments/assets/e15f10df-ba01-48ed-9f29-75db4fc745ef"
/>


### onboarding dropdowns
<img width="450" alt="SCR-20250102-mnbf"
src="https://github.com/user-attachments/assets/b9a733e4-dc98-4217-baca-9d1ed95d8980"
/>
<img width="435" alt="SCR-20250102-mnag"
src="https://github.com/user-attachments/assets/f05a781f-752a-4f4c-a4d3-af217773c6a3"
/>

### python onboarding
<img width="467" alt="SCR-20250107-jlgk"
src="https://github.com/user-attachments/assets/978a31ff-3929-480f-ae24-2d2cc48c17f8"
/>


### js onboarding
<img width="472" alt="SCR-20250114-jlyw"
src="https://github.com/user-attachments/assets/0c43d47d-15fe-4d3e-ae8d-85cf8afe3f12"
/>

### also updated generic python onboarding:
<img width="477" alt="SCR-20250114-kyvf"
src="https://github.com/user-attachments/assets/99aa6824-9e27-4b9f-96cc-3e548c5c8852"
/>

---------

Co-authored-by: Andrew Liu <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cmanallen cmanallen cmanallen approved these changes

@obostjancic obostjancic obostjancic approved these changes

@aliu39 aliu39 aliu39 approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michellewzhang @cmanallen @obostjancic @aliu39