Skip to content

fix(flutter-web): hide unactionable missing source context errors #62998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 15, 2024
Merged

fix(flutter-web): hide unactionable missing source context errors #62998

merged 4 commits into from
Jan 15, 2024

Conversation

buenaflor
Copy link
Contributor

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 11, 2024
@buenaflor
Copy link
Contributor Author

Wasn't sure who to tag as reviewer, pls feel free to tag someone who's a better fit for the review :)

@roggenkemper
Copy link
Member

Wasn't sure who to tag as reviewer, pls feel free to tag someone who's a better fit for the review :)

Yup, i'm the right person, thanks for the fix. lgtm

@buenaflor buenaflor merged commit 64ab138 into master Jan 15, 2024
@buenaflor buenaflor deleted the fix/flutter-web-hide-errors branch January 15, 2024 09:46
@buenaflor buenaflor mentioned this pull request Jan 15, 2024
Merged
@gggritso gggritso mentioned this pull request Jan 15, 2024
Merged
gggritso added a commit that referenced this pull request Jan 15, 2024
@gggritso
fix(style): Run Prettier on content actionable items (#63216)
b03cf39 
#62998 somehow snuck in
formatting that ESLint doesn't like. This is blocking FE deploys.
buenaflor added a commit that referenced this pull request Jan 16, 2024
@buenaflor
fix(flutter-web): use correct field when hiding unactionable source c…
c14e384 
…ontext errors (#63203)

change to `Source` to `source`

Relates to prev PR: #62998
trillville pushed a commit that referenced this pull request Jan 19, 2024
@buenaflor @trillville
fix(flutter-web): hide unactionable missing source context errors (#6…
60d39a6 
…2998)

Fixes getsentry/sentry-dart#1764
trillville pushed a commit that referenced this pull request Jan 19, 2024
@gggritso @trillville
fix(style): Run Prettier on content actionable items (#63216)
10820c9 
#62998 somehow snuck in
formatting that ESLint doesn't like. This is blocking FE deploys.
trillville pushed a commit that referenced this pull request Jan 19, 2024
@buenaflor @trillville
fix(flutter-web): use correct field when hiding unactionable source c…
853610a 
…ontext errors (#63203)

change to `Source` to `source`

Relates to prev PR: #62998
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roggenkemper roggenkemper roggenkemper approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide misleading source context errors from Dart/Flutter SDK for Flutter Web
2 participants
@buenaflor @roggenkemper