Skip to content

ref(getting-started): Update remix onboarding with wizard #58455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2023
Merged

ref(getting-started): Update remix onboarding with wizard #58455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7503b67
ref(getting-started): Update remix onboarding with wizard
Lms24 Oct 19, 2023
9ac087a
adjust tests
Lms24 Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions static/app/components/onboarding/productSelection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,6 @@ export const platformProductAvailability = {
ProductSolution.PERFORMANCE_MONITORING,
ProductSolution.SESSION_REPLAY,
],
'javascript-remix': [
ProductSolution.PERFORMANCE_MONITORING,
ProductSolution.SESSION_REPLAY,
],
'javascript-svelte': [
ProductSolution.PERFORMANCE_MONITORING,
ProductSolution.SESSION_REPLAY,
Expand Down
53 changes: 17 additions & 36 deletions static/app/gettingStartedDocs/javascript/remix.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,43 +1,24 @@
import {render, screen} from 'sentry-test/reactTestingLibrary';
import {renderWithOnboardingLayout} from 'sentry-test/onboarding/renderWithOnboardingLayout';
import {screen} from 'sentry-test/reactTestingLibrary';
import {textWithMarkupMatcher} from 'sentry-test/utils';

import {StepTitle} from 'sentry/components/onboarding/gettingStartedDoc/step';
import {ProductSolution} from 'sentry/components/onboarding/productSelection';
import docs from './remix';

import {GettingStartedWithRemix, nextSteps, steps} from './remix';
describe('javascript-remix onboarding docs', function () {
it('renders onboarding docs correctly', () => {
renderWithOnboardingLayout(docs);

describe('GettingStartedWithRemix', function () {
it('all products are selected', function () {
render(
<GettingStartedWithRemix
dsn="test-dsn"
projectSlug="test-project"
activeProductSelection={[
ProductSolution.PERFORMANCE_MONITORING,
ProductSolution.SESSION_REPLAY,
]}
/>
);
// Renders main headings
expect(screen.getByRole('heading', {name: 'Install'})).toBeInTheDocument();
expect(screen.getByRole('heading', {name: 'Configure SDK'})).toBeInTheDocument();
expect(screen.getByRole('heading', {name: 'Next Steps'})).toBeInTheDocument();

// Steps
for (const step of steps()) {
expect(
screen.getByRole('heading', {name: step.title ?? StepTitle[step.type]})
).toBeInTheDocument();
}
// Includes minimum required Astro version
expect(screen.getByText(textWithMarkupMatcher(/Remix 1.0.0/))).toBeInTheDocument();

// Next Steps
const filteredNextStepsLinks = nextSteps.filter(
nextStep =>
![
ProductSolution.PERFORMANCE_MONITORING,
ProductSolution.SESSION_REPLAY,
].includes(nextStep.id as ProductSolution)
);

for (const filteredNextStepsLink of filteredNextStepsLinks) {
expect(
screen.getByRole('link', {name: filteredNextStepsLink.name})
).toBeInTheDocument();
}
// Includes wizard command statement
expect(
screen.getByText(textWithMarkupMatcher(/npx @sentry\/wizard@latest -i remix/))
).toBeInTheDocument();
});
});
Loading