feat(replays): Add dead click issue detector #50149
Conversation
github-actions
bot
added
the
Scope: Backend
…ys-add-slow-click-detector
cmanallen
changed the base branch from
master
to
cmanallen/issues-add-replay-issue
| extra_event_data["event_id"] = event_id | ||
|
|
||
| occurrence = IssueOccurrence( | ||
| id=uuid.uuid4().hex, |
There was a problem hiding this comment.
what's the difference between id and event_id -- should either of them have some kind of deterministic value based on the event, or is random ok?
There was a problem hiding this comment.
I'm pretty sure random is okay. event_id and event["event_id"] should match but otherwise I think id can be whatever.
@wedamija Is this correct?
| "id": "1", | ||
| "username": "Test User", | ||
| "email": "[email protected]", | ||
| }, |
There was a problem hiding this comment.
Do we have access to all of the event schema here? If we do, we'd want to add also (in addition to @JoshFerge 's comment above):
"contexts": {
"browser": ..
"os": ..
"device": ..
},
"breadcrumb": [..]
The last 100 crumbs from the replay up to the timestamp of the triggered deadclick (not the click itself but including the timeout).
Wrt to event.sdk, do we report the value of the SDK that generated the click? Could be useful to track what data we have available and fixes to it.
There was a problem hiding this comment.
Until #50157 is merged I won't have that data but that's a good point that we should add this metadata.
wrt to breadcrumbs. Whats the formatting of these values?
There was a problem hiding this comment.
@bruno-garcia we don't have any of the context in this payload at the moment, i am working on getsentry/relay#2170 (from getsentry/rfcs#82) to fulfill this along with Colton's above PR.
I don't think we will be able to construct the breadcrumbs easily in the consumer here at the moment, its worth thinking about for replay issues if the issue breadcrumb should just query the replay recording directly for them.
|
|
||
| _report_slow_click_issue( | ||
| environment="prod", | ||
| fingerprint=payload["message"], |
There was a problem hiding this comment.
what is message here? is that the path of the HTML element?
There was a problem hiding this comment.
Yes, sentry's version of a CSS selector.
There was a problem hiding this comment.
I wonder how this will end up with duplicate / similar issues / new issues created when small changes are made to the DOM. something to think about for future iterations.
There was a problem hiding this comment.
overall this looks good to me. I am curious if this will create hundreds of issues upon deployment -- I believe with the issue platform there is a way to throttle this. Also, I think we should try on the ET org before the Sentry org, and roll it out slowly on the Sentry org.
Do we know the number of different messages we have already based on our tests? That'll be the number of issues we'll get
There was a problem hiding this comment.
I believe @billyvg had a query for this?
There was a problem hiding this comment.
1324 total deadclick rows, 518 rows when grouped by message (over unknown timeperiod (this is from bigquery))
84 of the 518 have > 1 occurrence
There was a problem hiding this comment.
The way I'm filtering we should create roughly ~300 issues in 3 weeks. I'm not sure if those issues will come at all once or if they will come gradually over that time period.
There was a problem hiding this comment.
it might be worth doing a bit of manual prodding of the particular issues now to see if we can find ones that are similar and come up with heuristics to see if we can combine them.
There was a problem hiding this comment.
and our "similarity" implementation for stacktrace issues for inspiration:
There was a problem hiding this comment.
The way I'm filtering we should create roughly ~300 issues in 3 weeks.
If that means we have 300 different broken buttons and anchors I think that's fine. Otherwise worth digging further
There was a problem hiding this comment.
overall this looks good to me. I am curious if this will create hundreds of issues upon deployment -- I believe with the issue platform there is a way to throttle this. Also, I think we should try on the ET org before the Sentry org, and roll it out slowly on the Sentry org.
…ys-add-slow-click-detector
…ys-add-slow-click-detector
yeah you've got a merge / rebase that's gone wrong -- effectively making it so you're doing the last N changes to master |
cmanallen
changed the base branch from
cmanallen/issues-add-replay-issue
to
master
cmanallen
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50149 +/- ##
=======================================
Coverage 81.11% 81.12%
=======================================
Files 4843 4846 +3
Lines 203288 203326 +38
Branches 11253 11253
=======================================
+ Hits 164904 164944 +40
+ Misses 38135 38133 -2
Partials 249 249
|
This reverts commit bb8840a.
…ys-add-slow-click-detector
* master: (52 commits) feat(replays): Add dead click issue detector (#50149) fix(sourcemaps): Improve metrics collection (#50293) ref(dynamic-sampling): Implement new abstraction for models (#50227) Revert "feat(backpressure): Proof of concept for queue monitoring service (#49872)" fix(dynamic-sampling): Remove duplicated queue declaration (#50283) feat(backpressure): Proof of concept for queue monitoring service (#49872) feat: Add pages for org auth tokens (#50225) feat(strings): Add span.category tag (#50286) feat(profiles): Count processed profiles in billing metrics consumer (#50047) feat(strings): Add `transaction.method` tag (#50237) ref(txnames): Increase sample size (#50278) ref(framework-suggestion-modal): Sort platforms by popularity (#50235) ref(hc): Only set the organizationmembermapping.member_id for monolith (#49789) ref(hc): Region name is set for organization mappings (#50257) fix(alert-details): Prevent environments call from being cancelled (#50270) fix(post-process-group): retry retrieving events from eventstore up to 3 times (#50210) fix(functions): Ensure selected functions projects are returned (#50194) styles(functions): Handle function name overflow in suspect functions (#50251) feat(functions): Add tooltip to slowest functions score (#50167) ref(routes): Avoid named exports for routes for now (#50255) ...
Adds experimental support for creating Replay issues on the issues-platform. The first issue type is "slow click" and will be available for Sentry org only. Slow clicks issues are only created for
timeoutendReasons onaandbuttontags.Depends on: #50148
Related: #48259