Skip to content

feat(issues): Add new replay issue type #50148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 2, 2023
Merged

feat(issues): Add new replay issue type #50148

merged 6 commits into from
Jun 2, 2023

Conversation

cmanallen
Copy link
Member

@cmanallen cmanallen commented Jun 1, 2023 •
edited
Loading

Adds the new slow click replay issue type.

Related: #48259

@cmanallen cmanallen requested a review from a team as a code owner June 1, 2023 13:01
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 1, 2023
@cmanallen cmanallen mentioned this pull request Jun 1, 2023
Merged
@cmanallen
Copy link
Member Author

@wedamija Can you help me with test coverage for this pull? I'm not sure where it should be added or how to fix the failing test.

@codecov
Copy link

codecov bot commented Jun 1, 2023 •
edited
Loading

Codecov Report

Merging #50148 (29137cb) into master (0bb5615) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 29137cb differs from pull request most recent head bb8840a. Consider uploading reports for the commit bb8840a to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #50148   +/-   ##
=======================================
  Coverage   81.10%   81.10%           
=======================================
  Files        4842     4842           
  Lines      203118   203126    +8     
  Branches    11270    11270           
=======================================
+ Hits       164740   164751   +11     
+ Misses      38129    38126    -3     
  Partials      249      249
Impacted Files Coverage Δ
src/sentry/issues/grouptype.py 99.22% <100.00%> (+0.02%) ⬆️

... and 5 files with indirect coverage changes

@cmanallen cmanallen merged commit a56f6ce into master Jun 2, 2023
@cmanallen cmanallen deleted the cmanallen/issues-add-replay-issue branch June 2, 2023 18:08
cmanallen added a commit that referenced this pull request Jun 5, 2023
@cmanallen
feat(replays): Add dead click issue detector (#50149)
23252ef 
Adds experimental support for creating Replay issues on the
issues-platform. The first issue type is "slow click" and will be
available for Sentry org only. Slow clicks issues are only created for
`timeout` endReasons on `a` and `button` tags.

Depends on: #50148
Related: #48259
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wedamija wedamija wedamija approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmanallen @wedamija