Skip to content
This repository was archived by the owner on Nov 20, 2023. It is now read-only.

feat: Add a means to detect if the CLI binary exists #402

Merged
merged 1 commit into from
Oct 31, 2022
Merged

feat: Add a means to detect if the CLI binary exists #402

merged 1 commit into from
Oct 31, 2022

Conversation

timfish
Copy link
Contributor

@timfish timfish commented Oct 24, 2022 •
edited
Loading

It would be great if downstream consumers of the webpack plugin could check if the binary has successfully downloaded

Ref: getsentry/sentry-javascript#6015

@timfish timfish marked this pull request as ready for review October 24, 2022 15:18
@timfish timfish mentioned this pull request Oct 25, 2022
Closed
lobsterkatie
lobsterkatie approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lforst lforst merged commit 8121aaf into getsentry:master Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@lforst lforst lforst approved these changes

@lobsterkatie lobsterkatie lobsterkatie approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timfish @lforst @lobsterkatie