-
-
Notifications
You must be signed in to change notification settings - Fork 171
ref(log): send logs by default when logs feature flag is enabled #915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #915 +/- ##
==========================================
+ Coverage 73.48% 73.51% +0.02%
==========================================
Files 64 64
Lines 7533 7533
==========================================
+ Hits 5536 5538 +2
+ Misses 1997 1995 -2 |
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Long term, I would consider completely removing the enable_logs flag, and have setting/unsetting the feature flag be the only way to enable/disable logs
|
@szokeasaurusrex Thanks. I also have this #910 which sets |
|
@lcian Ah I was more referring to that we maybe should consider completely removing the flag, so that you cannot disable logs if the logs feature flag is turned on |
Description
Removes the double opt-in for the
logcrate integration, as we'll now map to both anexception/breadcrumband alogwhen thelogsfeature flag is active and the level is at or above INFO.If the user has set
enable_logs: falsein their client options, the log will be created but dropped when it reaches theclient.This creates the log uselessly to later discard it. Still, in 99% of cases, if I use the
logsfeature flag, it means I want to get logs, so most probablyenable_logs == trueand the log is actually used.This change is analogous to the one we already did for the
tracingintegration.Issues
Closes #909
Closes RUST-112