Skip to content

ref(tracing): Don't create an exception if the event doesn't have one #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2022
Merged

ref(tracing): Don't create an exception if the event doesn't have one #423

merged 1 commit into from
Jan 31, 2022

Conversation

loewenheim
Copy link
Contributor

No description provided.

@loewenheim loewenheim merged commit a00b91b into master Jan 31, 2022
@loewenheim loewenheim deleted the ref/error-type branch January 31, 2022 13:31
@flub
Copy link
Contributor

flub commented Jan 31, 2022

Don't forget to add a changelog, this is a user-visible change. i imagine the contributor of this will need adjusting at the least

@loewenheim loewenheim mentioned this pull request Jan 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

+1 more reviewer

@flub flub flub approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loewenheim @flub @Swatinem