Skip to content

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Jul 23, 2024

Copy link

github-actions bot commented Jul 23, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- WIP 6.0 major ([#2352](https://github.com/getsentry/sentry-ruby/pull/2352))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against ebe5268

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.43%. Comparing base (1da1c2d) to head (ebe5268).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2352      +/-   ##
==========================================
+ Coverage   97.31%   97.43%   +0.12%     
==========================================
  Files         144      143       -1     
  Lines        5652     5612      -40     
==========================================
- Hits         5500     5468      -32     
+ Misses        152      144       -8     
Components Coverage Δ
sentry-ruby 97.72% <100.00%> (-0.06%) ⬇️
sentry-rails 96.59% <100.00%> (+0.97%) ⬆️
sentry-sidekiq 96.57% <ø> (ø)
sentry-resque 94.44% <ø> (ø)
sentry-delayed_job 94.68% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-rails/lib/sentry/rails/active_job.rb 98.46% <100.00%> (+1.40%) ⬆️
...s/lib/sentry/rails/overrides/streaming_reporter.rb 71.42% <ø> (+9.89%) ⬆️
sentry-ruby/lib/sentry/background_worker.rb 97.43% <100.00%> (-0.19%) ⬇️
sentry-ruby/lib/sentry/breadcrumb.rb 93.93% <100.00%> (ø)
sentry-ruby/lib/sentry/breadcrumb_buffer.rb 96.42% <100.00%> (ø)
sentry-ruby/lib/sentry/check_in_event.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/client.rb 99.36% <100.00%> (-0.05%) ⬇️
sentry-ruby/lib/sentry/configuration.rb 98.40% <100.00%> (ø)
sentry-ruby/lib/sentry/cron/monitor_config.rb 95.45% <100.00%> (ø)
sentry-ruby/lib/sentry/cron/monitor_schedule.rb 100.00% <100.00%> (ø)
... and 18 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sl0thentr0py sl0thentr0py force-pushed the 6.0-dev branch 2 times, most recently from 98355b1 to 7d6edaf Compare October 31, 2024 13:48
* Migrate from to_hash to to_h

As @solnic pointed out in #2350 (comment)
`to_hash` has special meaning in Ruby and could be called implicitly
in contexts like double splatting argument. So we should switch to `to_h`
to avoid potential issues.
@sl0thentr0py sl0thentr0py force-pushed the 6.0-dev branch 4 times, most recently from 3a07852 to 10946fb Compare September 17, 2025 10:57
* Cleanup before_send to only apply to ErrorEvent
* remove the Hash deprecation message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants