Skip to content

Conversation

@alexander-alderman-webb
Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb commented Nov 6, 2025

Description

Set the default value for max_spans option of LangchainIntegration to None, so that langchain spans are not exited early by default.

Deprecate the option as well, announcing its removal in the next major.

Issues

Closes #4985
Closes PY-1914

Reminders

@linear
Copy link

linear bot commented Nov 6, 2025

@codecov
Copy link

codecov bot commented Nov 6, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
27851 1 27850 2207
View the full list of 1 ❄️ flaky test(s)
tests.profiler.test_continuous_profiler::test_continuous_profiler_auto_start_and_manual_stop[non-experiment-start_profile_session/stop_profile_session (deprecated)-thread]

Flake rate in main: 100.00% (Passed 0 times, Failed 31 times)

Stack Traces | 0.177s run time
tests/profiler/test_continuous_profiler.py:270: in test_continuous_profiler_auto_start_and_manual_stop
    assert_single_transaction_with_profile_chunks(envelopes, thread)
tests/profiler/test_continuous_profiler.py:147: in assert_single_transaction_with_profile_chunks
    assert len(items["profile_chunk"]) > 0
E   assert 0 > 0
E    +  where 0 = len([])

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@linear
Copy link

linear bot commented Nov 6, 2025

@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review November 6, 2025 10:04
@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner November 6, 2025 10:04
@alexander-alderman-webb alexander-alderman-webb changed the title chore: Deprecate maximum lanchain spans option chore: Deprecate maximum LangChain spans option Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove max_spans from LangchainIntegration

2 participants