-
Notifications
You must be signed in to change notification settings - Fork 570
Use weakref in dedupe where possible #4834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All tests passed in 2585.21s |
89ea5eb to
a7529ed
Compare
a7529ed to
d24da87
Compare
Member
Author
|
with the fix in this PR, the code from #3165 (comment) gives before(.venv) [neel@vheissu vanilla]$ python app.py
ERROR:root:Exception logging
Traceback (most recent call last):
File "/run/media/neel/m2/sentry/sentry_sample_apps/python/vanilla/app.py", line 16, in <module>
raise CustomException('Custom Exception')
CustomException: Custom Exception
Custom Exception
Custom Exception
Custom Exception
Custom Exception
Custom Exception
Custom Exception
Custom Exception
Custom Exception
Custom Exception
Custom Exception
^CException was garbage collected!after(.venv) [neel@vheissu vanilla]$ python app.py
ERROR:root:Exception logging
Traceback (most recent call last):
File "/run/media/neel/m2/sentry/sentry_sample_apps/python/vanilla/app.py", line 16, in <module>
raise CustomException('Custom Exception')
CustomException: Custom Exception
Exception was garbage collected!
None
None
None
None |
antonpirker
approved these changes
Sep 22, 2025
Contributor
antonpirker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot use
weakrefalways since built-in exception types likeZeroDivisionErrorraise aTypeError.This makes the memory usage at least a little better for custom exception types.
Issues