Skip to content

fix(flags): Fix bug where concurrent accesses to the flags property could raise a RunTime error #4034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2025

Add types

dfd6cef
Select commit
Loading
Failed to load commit list.
Merged

fix(flags): Fix bug where concurrent accesses to the flags property could raise a RunTime error #4034

Add types
dfd6cef
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 10, 2025 in 1s

44.92% (-35.32%) compared to d670a15

View this Pull Request on Codecov

44.92% (-35.32%) compared to d670a15

Details

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 44.92%. Comparing base (d670a15) to head (dfd6cef).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/feature_flags.py 82.35% 2 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (d670a15) and HEAD (dfd6cef). Click for more details.

HEAD has 83 uploads less than BASE
Flag BASE (d670a15) HEAD (dfd6cef)
125 42
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4034       +/-   ##
===========================================
- Coverage   80.23%   44.92%   -35.32%     
===========================================
  Files         139      139               
  Lines       15415    15427       +12     
  Branches     2604     2605        +1     
===========================================
- Hits        12368     6930     -5438     
- Misses       2203     7801     +5598     
+ Partials      844      696      -148     
Files with missing lines Coverage Δ
sentry_sdk/feature_flags.py 75.00% <82.35%> (-5.00%) ⬇️

... and 102 files with indirect coverage changes