Skip to content

Conversation

@antonpirker
Copy link
Contributor

@antonpirker antonpirker commented Nov 27, 2024

The docker image name of the official Clickhouse docker image changed, so I updated our GH action that starts that docker container and reference the new version here.


Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.

@codecov
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.94%. Comparing base (da20623) to head (9f0bfc4).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3826      +/-   ##
==========================================
+ Coverage   79.92%   79.94%   +0.01%     
==========================================
  Files         137      137              
  Lines       15421    15421              
  Branches     2614     2614              
==========================================
+ Hits        12326    12329       +3     
+ Misses       2225     2223       -2     
+ Partials      870      869       -1     

see 5 files with indirect coverage changes

@antonpirker antonpirker enabled auto-merge (squash) November 27, 2024 13:25
@antonpirker antonpirker merged commit 7022446 into master Nov 27, 2024
136 checks passed
@antonpirker antonpirker deleted the antonpirker/fix-clickhouse-tests branch November 27, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants