Skip to content

Conversation

@gmcrocetti
Copy link
Contributor

@gmcrocetti gmcrocetti commented Nov 6, 2024

add capability for the logging integration to use the parameter 'stack_info' (added in Python 3.2). When set to True the stack trace will be retrieved and properly handled.

This feature is mapped in this issue.


Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.

@gmcrocetti gmcrocetti changed the title Handle the parameter stack_info in the LoggingIntegration [issue-2804] Handle the parameter stack_info in the LoggingIntegration Nov 6, 2024
@gmcrocetti gmcrocetti changed the title [issue-2804] Handle the parameter stack_info in the LoggingIntegration [issue-2804] Handle the parameter stack_info for the LoggingIntegration Nov 6, 2024
…k_info' (added in Python 3.2). When set to True the stack trace will be retrieved and properly handled
Copy link
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Thanks for adding this! Really cool! 💯

@codecov
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.37%. Comparing base (c2dfbcc) to head (8d62604).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3745      +/-   ##
==========================================
- Coverage   84.38%   84.37%   -0.02%     
==========================================
  Files         136      136              
  Lines       14375    14375              
  Branches     2422     2422              
==========================================
- Hits        12131    12129       -2     
+ Misses       1495     1494       -1     
- Partials      749      752       +3     
Files with missing lines Coverage Δ
sentry_sdk/integrations/logging.py 94.73% <100.00%> (ø)

... and 3 files with indirect coverage changes

@antonpirker antonpirker merged commit 200d0cd into getsentry:master Nov 7, 2024
137 of 139 checks passed
@gmcrocetti
Copy link
Contributor Author

Looks good!

Thanks for adding this! Really cool! 💯

Amazing ! 🚀
I'm glad it worked 💪 . Thanks for reviewing it !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants