Skip to content

Conversation

@szokeasaurusrex
Copy link
Member

Rename the action that checks that all our pinned-version tests for our integrations are named "All pinned XXX tests passed" rather than just "All XXX tests passed." The old name was confusing because the action only checks that the pinned tests have passed.

Rename the action that checks that all our pinned-version tests for our integrations are named "All pinned XXX tests passed" rather than just "All XXX tests passed." The old name was confusing because the action only checks that the pinned tests have passed.
@codecov
Copy link

codecov bot commented Oct 29, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
13593 1 13592 4115
View the top 1 failed tests by shortest run time
tests.integrations.sanic.test_sanic test_error_in_errorhandler
Stack Traces | 0.108s run time
.../integrations/sanic/test_sanic.py:201: in test_error_in_errorhandler
    with c as client:
.tox/py3.11-sanic-latest/lib/python3.11........./site-packages/sanic_testing/reusable.py:65: in __enter__
    self.run()
.tox/py3.11-sanic-latest/lib/python3.11........./site-packages/sanic_testing/reusable.py:77: in run
    self._server = self._run(self._server_co)
.tox/py3.11-sanic-latest/lib/python3.11........./site-packages/sanic_testing/reusable.py:198: in _run
    return self._loop.run_until_complete(coro)
.../hostedtoolcache/Python/3.11.10....../x64/lib/python3.11/asyncio/base_events.py:654: in run_until_complete
    return future.result()
.tox/py3.11-sanic-latest/lib/python3.11.../sanic/mixins/startup.py:613: in create_server
    return await serve(
.tox/py3.11-sanic-latest/lib/python3.11.../sanic/server/async_server.py:113: in __await__
    self.server = task.result()
.../hostedtoolcache/Python/3.11.10....../x64/lib/python3.11/asyncio/base_events.py:1536: in create_server
    raise OSError(err.errno, msg) from None
E   OSError: [Errno 98] error while attempting to bind on address ('127.0.0.1', 37944): address already in use

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@szokeasaurusrex szokeasaurusrex merged commit d48dc46 into master Oct 29, 2024
135 of 136 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/ci-pinned-clarification branch October 29, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants