Fix flaky transport test #3666
Merged
Fix flaky transport test #3666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3666 +/- ##
==========================================
- Coverage 84.32% 84.30% -0.02%
==========================================
Files 133 133
Lines 14226 14227 +1
Branches 2398 2398
==========================================
- Hits 11996 11994 -2
- Misses 1487 1489 +2
- Partials 743 744 +1
|
antonpirker
approved these changes
Oct 17, 2024
Contributor
antonpirker
left a comment
antonpirker
left a comment
There was a problem hiding this comment.
Looks good. Python 3.6 and brotli is probably a combination that is not that common (according to my gut feeling)
sl0thentr0py
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_transport_workstest is flaking ~7 our of 10 times after adding brotli, but only on 3.6 with gevent and only in CI.