Skip to content

Conversation

@antonpirker
Copy link
Contributor

Attaching the database explain plan to a db span was an experimental feature done in an Sentry Hackweek.

As we are moving into an Otel world, we remove this experiment from our Repository.

There is still a branch experiment/explain_plans on Github to keep the code for future reference:
https://github.com/getsentry/sentry-python/tree/experiment/explain_plans

(maybe we can copy the code into the Opentelemetry instrumentation if we want to see this feature in the future)

@antonpirker antonpirker added the Component: SDK Core Dealing with the core of the SDK label Sep 13, 2024
@antonpirker antonpirker self-assigned this Sep 13, 2024
@codecov
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.45%. Comparing base (e6ca5a2) to head (a48ed4b).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3534      +/-   ##
==========================================
+ Coverage   84.22%   84.45%   +0.23%     
==========================================
  Files         136      133       -3     
  Lines       13900    13833      -67     
  Branches     2940     2927      -13     
==========================================
- Hits        11707    11683      -24     
+ Misses       1465     1422      -43     
  Partials      728      728              
Files with missing lines Coverage Δ
sentry_sdk/consts.py 99.50% <ø> (ø)
sentry_sdk/integrations/django/__init__.py 85.15% <ø> (+0.38%) ⬆️
sentry_sdk/integrations/sqlalchemy.py 66.66% <ø> (+2.71%) ⬆️

... and 2 files with indirect coverage changes

@antonpirker antonpirker marked this pull request as ready for review September 13, 2024 10:16
@antonpirker antonpirker merged commit 23ef8ca into master Sep 13, 2024
@antonpirker antonpirker deleted the antonpirker/remove-experimental-explain-plans branch September 13, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: SDK Core Dealing with the core of the SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants