Skip to content

Conversation

@sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Sep 5, 2024

The logger test never actually worked as designed (app.logger was never a thing). The 500 error doesn't really test any Bottle-related functionality.

@sentrivana sentrivana marked this pull request as ready for review September 5, 2024 15:00
Copy link
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@antonpirker antonpirker merged commit 6814df9 into master Sep 5, 2024
@antonpirker antonpirker deleted the ivana/fix-bottle branch September 5, 2024 15:14
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this pull request Sep 30, 2024
The logger test never actually worked as designed (app.logger was never a thing). The 500 error doesn't really test any Bottle-related functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants