Skip to content

Conversation

@sl0thentr0py
Copy link
Member

@codecov
Copy link

codecov bot commented Aug 27, 2024

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
11482 4 11478 1635
View the top 3 failed tests by shortest run time
tests.integrations.aws_lambda.test_aws test_init_error[python3.11]
Stack Traces | 11.8s run time
.../integrations/aws_lambda/test_aws.py:334: in test_init_error
    (event,) = envelope_items
E   ValueError: not enough values to unpack (expected 1, got 0)
tests.integrations.aws_lambda.test_aws test_init_error[python3.12]
Stack Traces | 12.8s run time
.../integrations/aws_lambda/test_aws.py:334: in test_init_error
    (event,) = envelope_items
E   ValueError: not enough values to unpack (expected 1, got 0)
tests.integrations.aws_lambda.test_aws test_init_error[python3.9]
Stack Traces | 17s run time
.../integrations/aws_lambda/test_aws.py:334: in test_init_error
    (event,) = envelope_items
E   ValueError: not enough values to unpack (expected 1, got 0)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@sl0thentr0py sl0thentr0py force-pushed the neel/scrubber-pii-separate-lis branch from 7c1cbe2 to c55293d Compare August 27, 2024 11:43
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please also add to docs

@sl0thentr0py
Copy link
Member Author

docs here
getsentry/sentry-docs#11154

@sl0thentr0py sl0thentr0py force-pushed the neel/scrubber-pii-separate-lis branch 2 times, most recently from 5f66211 to 12fbaa5 Compare August 27, 2024 12:47
@sl0thentr0py sl0thentr0py force-pushed the neel/scrubber-pii-separate-lis branch from 12fbaa5 to a31b05f Compare August 27, 2024 13:27
@sl0thentr0py sl0thentr0py enabled auto-merge (squash) August 27, 2024 13:27
@sl0thentr0py sl0thentr0py merged commit ad39086 into master Aug 27, 2024
@sl0thentr0py sl0thentr0py deleted the neel/scrubber-pii-separate-lis branch August 27, 2024 13:35
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run EventScrubber with send_default_pii=True

3 participants