test(basics): Replace push_scope
#3353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sentrivana
approved these changes
Jul 26, 2024
sl0thentr0py
approved these changes
Jul 26, 2024
Most of the `push_scope` usages in `test_basics.py` need to stay, as they test functionality specific to `push_scope`. However, in `test_scope_event_processor_order`, the `push_scope` can be replaced with `new_scope`. We make this replacement here. Ref: #3345
szokeasaurusrex
force-pushed
the
szokeasaurusrex/configure-scope-3-deprecation
branch
from
6ad6b96 to
6f11f50
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/push_scope-0
branch
from
0b60ace to
20ed5b7
Compare
Base automatically changed from
szokeasaurusrex/configure-scope-3-deprecation
to
master
July 26, 2024 13:27
arjennienhuis
pushed a commit
to arjennienhuis/sentry-python
that referenced
this pull request
Sep 30, 2024
Most of the `push_scope` usages in `test_basics.py` need to stay, as they test functionality specific to `push_scope`. However, in `test_scope_event_processor_order`, the `push_scope` can be replaced with `new_scope`. We make this replacement here. Ref: getsentry#3345
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the
push_scopeusages intest_basics.pyneed to stay, asthey test functionality specific to
push_scope.However, in
test_scope_event_processor_order, thepush_scopecanbe replaced with
new_scope. We make this replacement here.Ref: #3345