Skip to content

feat(pymongo): Set MongoDB tags directly on span data #3290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 17, 2024
Merged

feat(pymongo): Set MongoDB tags directly on span data #3290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7b40b65
feat(pymongo): Set MongoDB tags directly on span data
0Calories Jul 12, 2024
1df7a9b
update test to check on data
0Calories Jul 12, 2024
386ba97
rename to common data
0Calories Jul 12, 2024
234946c
bring back call to set_tag
0Calories Jul 15, 2024
c019fde
update test
0Calories Jul 15, 2024
8a438f4
add missing assertions
0Calories Jul 16, 2024
9a2c4a3
Update sentry_sdk/integrations/pymongo.py
0Calories Jul 16, 2024
bc02dc7
Merge branch 'master' into ashanand/pymongo/mongo-tags-on-span-data
0Calories Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sentry_sdk/integrations/pymongo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,12 @@ def started(self, event):
)

for tag, value in tags.items():
# set the tag for backwards-compatibility.
# TODO: remove the set_tag call in the next major release!
span.set_tag(tag, value)

span.set_data(tag, value)

for key, value in data.items():
span.set_data(key, value)

Expand Down
7 changes: 7 additions & 0 deletions tests/integrations/pymongo/test_pymongo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,21 +62,28 @@ def test_transactions(sentry_init, capture_events, mongo_server, with_pii):
assert span["data"][SPANDATA.SERVER_PORT] == mongo_server.port
for field, value in common_tags.items():
assert span["tags"][field] == value
assert span["data"][field] == value

assert find["op"] == "db"
assert insert_success["op"] == "db"
assert insert_fail["op"] == "db"

assert find["data"]["db.operation"] == "find"
assert find["tags"]["db.operation"] == "find"
assert insert_success["data"]["db.operation"] == "insert"
assert insert_success["tags"]["db.operation"] == "insert"
assert insert_fail["data"]["db.operation"] == "insert"
assert insert_fail["tags"]["db.operation"] == "insert"

assert find["description"].startswith('{"find')
assert insert_success["description"].startswith('{"insert')
assert insert_fail["description"].startswith('{"insert')

assert find["data"][SPANDATA.DB_MONGODB_COLLECTION] == "test_collection"
assert find["tags"][SPANDATA.DB_MONGODB_COLLECTION] == "test_collection"
assert insert_success["data"][SPANDATA.DB_MONGODB_COLLECTION] == "test_collection"
assert insert_success["tags"][SPANDATA.DB_MONGODB_COLLECTION] == "test_collection"
assert insert_fail["data"][SPANDATA.DB_MONGODB_COLLECTION] == "erroneous"
assert insert_fail["tags"][SPANDATA.DB_MONGODB_COLLECTION] == "erroneous"
if with_pii:
assert "1" in find["description"]
Expand Down