ref(types): Correct ExcInfo type
#3266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3266 +/- ##
==========================================
- Coverage 79.41% 79.41% -0.01%
==========================================
Files 132 132
Lines 14263 14265 +2
Branches 2992 2993 +1
==========================================
+ Hits 11327 11328 +1
Misses 2091 2091
- Partials 845 846 +1
|
antonpirker
approved these changes
Jul 10, 2024
Previously, we defined `ExcInfo` as `tuple[Type[BaseException] | None, BaseException | None, TracebackType | None]`, when in fact, the correct type is the narrower `tuple[Type[BaseException], BaseException, TracebackType | None] | tuple[None, None, None]`.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/improve-ExcInfo-type
branch
from
8d691f9 to
1f17f46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we defined
ExcInfoastuple[Type[BaseException] | None, BaseException | None, TracebackType | None], when in fact, the correct type is the narrowertuple[Type[BaseException], BaseException, TracebackType | None] | tuple[None, None, None].This change makes b0b5ecc (included in #3264) possible; previously, we would have gotten a mypy error when passing the ExcInfo tuple to
logger.error