fix(tracing): Only propagate headers from spans within transactions #3070
+78
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
commented
May 14, 2024
antonpirker
approved these changes
May 14, 2024
Contributor
|
This breaks now a lot of tests because they assume |
szokeasaurusrex
changed the title
szokeasaurusrex
force-pushed
the
szokeasaurusrex/no-propagation-transactionless-spans
branch
from
e42bac5 to
a1d0c76
Compare
szokeasaurusrex
commented
May 15, 2024
This change ensures that we only propagate trace headers from spans that are within a transaction. This fixes a bug where any child transactions of a span created outside a transaction are missing a dynamic sampling context and are part of a trace missing a root transaction (because the root is the span). Also, remove/modify tests that were asserting the old behavior. Fixes #3068
szokeasaurusrex
force-pushed
the
szokeasaurusrex/no-propagation-transactionless-spans
branch
from
a1d0c76 to
94a6c2a
Compare
szokeasaurusrex
deleted the
szokeasaurusrex/no-propagation-transactionless-spans
branch
This was referenced Jun 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that we only propagate trace headers from spans that are within a transaction. This fixes a bug where any child transactions of a span created outside a transaction are missing a dynamic sampling context and are part of a trace missing a root transaction (because the root is the span).
Fixes #3068