Skip to content

feat(redis): Add db.system to remaining redis spans #2271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2023
Merged

feat(redis): Add db.system to remaining redis spans #2271

merged 1 commit into from
Jul 25, 2023

Conversation

AbhiPrasad
Copy link
Member

In #2038 we didn't add db.system to all the redis spans. This PR adds db.system span data to the redis spans we missed.

resolves https://www.notion.so/sentry/db-system-value-is-missing-in-Redis-spans-1c381ac16d724a58bbefd98481c93545

gggritso
gggritso approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@AbhiPrasad AbhiPrasad merged commit 9a0e864 into master Jul 25, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-db-redis-data-full branch July 25, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gggritso gggritso gggritso approved these changes

@sentrivana sentrivana sentrivana approved these changes

@antonpirker antonpirker Awaiting requested review from antonpirker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbhiPrasad @gggritso @sentrivana