fix(crons): Do not send monitor_config when unset #2058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression introduced in 1.18 which caused monitor check-ins without a `monitor_config` to be rejected by relay.
evanpurkhiser
commented
Apr 28, 2023
| assert check_in["monitor_slug"] == "abc123" | ||
| assert check_in["monitor_config"] == monitor_config | ||
|
|
||
| # Without passing a monitor_config the field is not in the checkin |
There was a problem hiding this comment.
This is the case that catches the regression
HazAT
approved these changes
Apr 28, 2023
HazAT
deleted the
evanpurkhiser/fix-crons-do-not-send-monitor-config-when-unset
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in 1.18 which caused monitor
check-ins without a
monitor_configto be rejected by relay.Fixes #2052