TypeError using SentryAsgiMiddleware with FastAPI/Starlette app

[Stigjb]

I cannot get SentryAsgiMiddleware to work with our FastAPI app. We tried to follow the example in the Sentry docs, so the app module basically looks like this:

from fastapi import FastAPI
from sentry_sdk.integrations.asgi import SentryAsgiMiddleware
...
app = FastAPI()

@app.post()
...

app = SentryAsgiMiddleware(app)

This gives an error on all requests, see the following stack trace:

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/uvicorn/protocols/http/httptools_impl.py", line 385, in run_asgi
    result = await app(self.scope, self.receive, self.send)
  File "/usr/local/lib/python3.7/site-packages/uvicorn/middleware/proxy_headers.py", line 45, in __call__
    return await self.app(scope, receive, send)
  File "/usr/local/lib/python3.7/site-packages/uvicorn/middleware/asgi2.py", line 7, in __call__
    await instance(receive, send)
  File "/usr/local/lib/python3.7/site-packages/sentry_sdk/integrations/asgi.py", line 54, in run_asgi2
    scope, lambda: self.app(scope)(receive, send)
  File "/usr/local/lib/python3.7/site-packages/sentry_sdk/integrations/asgi.py", line 93, in _run_app
    raise exc from None
  File "/usr/local/lib/python3.7/site-packages/sentry_sdk/integrations/asgi.py", line 90, in _run_app
    return await callback()
  File "/usr/local/lib/python3.7/site-packages/sentry_sdk/integrations/asgi.py", line 54, in <lambda>
    scope, lambda: self.app(scope)(receive, send)
TypeError: __call__() missing 2 required positional arguments: 'receive' and 'send'

Library versions:

• python==3.7.5
• sentry-sdk==0.13.2
• uvicorn==0.10.8
• fastapi==0.42.0
• starlette==0.12.9

[untitaker]

It seems like uvicorn might inspect the function signature to figure out which ASGI version to use. Our function signature is *args, **kwargs, because we choose the ASGI version depending on the ASGI version we are called with. So uvicorn doesn't know how to call the app, but the app is wrapped with a middleware (Sentry) that doesn't know either.

I have a vague idea on how to fix this (middleware inspects app's function signature).

Could you try setting this option: https://www.uvicorn.org/settings/#application-interface (try all values except auto)

[Stigjb]

We run the server with gunicorn and uvicorn.workers.UvicornWorker, which makes it a bit inconvenient to change options in Uvicorn. We found a suggestion to subclass the UvicornWorker to change the config, will try that and report back.

[Stigjb]

The service is running now, after specifying ASGI3 interface using the following worker class:

from uvicorn.workers import UvicornWorker


class GunicornUvicornWorker(UvicornWorker):
    CONFIG_KWARGS = {"loop": "uvloop", "http": "httptools", "interface": "asgi3"}

[untitaker]

ok we will fix this in the sentry sdk in any case. thanks for reporting!

[untitaker]

@Stigjb could you try out #557 while reverting your workaround?

[Stigjb]

I deployed the project using the standard UvicornWorker and the PR branch at #557, and it worked fine! 👍

[Stigjb]

We really appreciate the quick response! When is the next release planned?

[untitaker]

@Stigjb sometime this week

[untitaker]

0.13.3 has been released, sorry for the delay