Skip to content

feat: crashpad handler http-proxy support #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
supervacuus merged 9 commits into from
May 27, 2023
Merged

feat: crashpad handler http-proxy support #847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f318826
crashpad backend starts handler with http-proxy
supervacuus May 20, 2023
51a38db
Fix bool success in crashpad backend.
supervacuus May 22, 2023
52967de
Update crashpad submodule
supervacuus May 22, 2023
822561f
Update crashpad submodule for Linux support
supervacuus May 22, 2023
63578ae
Update crashpad submodule
supervacuus May 22, 2023
0c8b778
add change-log
supervacuus May 22, 2023
b651d3e
fix format for clang-format 15
supervacuus May 22, 2023
02e0948
Update crashpad submodule with apple fixes.
supervacuus May 22, 2023
18d2562
Update crashpad submodule
supervacuus May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- Disable PC adjustment in the backend for libunwindstack ([#839](https://github.com/getsentry/sentry-native/pull/839))
- Crashpad backend allows inspection and enrichment of the crash event in the on_crash/before_send hooks ([#843](https://github.com/getsentry/sentry-native/pull/843))
- Add http-proxy support to the `crashpad_handler` ([#847](https://github.com/getsentry/sentry-native/pull/847), [crashpad#86](https://github.com/getsentry/crashpad/pull/86))

**Internal**:

Expand Down
2 changes: 1 addition & 1 deletion external/crashpad
Open in desktop
Submodule crashpad updated 17 files
+1 −0 .github/CODEOWNERS
+5 −0 client/client_argv_handling.cc
+1 −0 client/client_argv_handling.h
+7 −0 client/crashpad_client.h
+6 −3 client/crashpad_client_linux.cc
+26 −12 client/crashpad_client_mac.cc
+10 −0 client/crashpad_client_win.cc
+1 −1 client/ios_handler/in_process_handler.cc
+7 −3 handler/crash_report_upload_thread.cc
+3 −1 handler/crash_report_upload_thread.h
+9 −0 handler/handler_main.cc
+8 −0 tools/run_with_crashpad.cc
+4 −0 util/net/http_transport.cc
+7 −0 util/net/http_transport.h
+3 −0 util/net/http_transport_libcurl.cc
+126 −35 util/net/http_transport_mac.mm
+37 −11 util/net/http_transport_win.cc
22 changes: 16 additions & 6 deletions src/backends/sentry_backend_crashpad.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,15 +319,25 @@ crashpad_backend_startup(
// `sentry_init` will persist the upload flag.
data->db = crashpad::CrashReportDatabase::Initialize(database).release();

bool success;
crashpad::CrashpadClient client;
char *minidump_url
= sentry__dsn_get_minidump_url(options->dsn, options->user_agent);
SENTRY_TRACEF("using minidump url \"%s\"", minidump_url);
std::string url = minidump_url ? std::string(minidump_url) : std::string();
sentry_free(minidump_url);
bool success = client.StartHandler(handler, database, database, url,
annotations, arguments, /* restartable */ true,
/* asynchronous_start */ false, attachments);
if (minidump_url) {
SENTRY_TRACEF("using minidump URL \"%s\"", minidump_url);
success = client.StartHandler(handler, database, database, minidump_url,
options->http_proxy ? options->http_proxy : "", annotations,
arguments,
/* restartable */ true,
/* asynchronous_start */ false, attachments);
sentry_free(minidump_url);
} else {
SENTRY_WARN(
"failed to construct minidump URL (check DSN or user-agent)");
delete data->db;
data->db = nullptr;
return 1;
}

#ifdef CRASHPAD_WER_ENABLED
sentry_path_t *handler_dir = sentry__path_dir(absolute_handler_path);
Expand Down