Skip to content

fix(astro): Handle non-utf8 encoded streams in middleware #9989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2023
Merged

fix(astro): Handle non-utf8 encoded streams in middleware #9989

merged 1 commit into from
Dec 28, 2023

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Dec 28, 2023

Ref #9985

Some context on the proposed change: whatwg/encoding#184

@lforst lforst mentioned this pull request Dec 28, 2023
Closed
3 tasks
Lms24
Lms24 approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting! Never heard of this, thx for looking this up and fixing

anonrig
anonrig reviewed Dec 28, 2023
View reviewed changes
@lforst lforst merged commit 66ea1e6 into develop Dec 28, 2023
@lforst lforst deleted the lforst-9985 branch December 28, 2023 17:02
anonrig pushed a commit that referenced this pull request Jan 3, 2024
@anonrig
fix(astro): Handle non-utf8 encoded streams in middleware (#9989)
8f6dd08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

+1 more reviewer

@anonrig anonrig anonrig approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lforst @anonrig @Lms24