-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(node): Instrumentation for node-cron
library
#9904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO let's namespace all the cron instrumentation under Sentry.cron.instrumentNodeCron
. We don't have to care about treeshaking for this, and we avoid polluting global namespace.
gonna test something out with this PR |
I've moved |
node-cron
for check-insnode-cron
library
This is now exported from all the downstream packages. |
Closes #9892
Usage