feat(node): Vendor cookie module
#9308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Oct 19, 2023
|
Ehhhh, we actually use |
|
@alfaproject please see https://develop.sentry.dev/sdk/philosophy/#dependencies-cost - we try to avoid using deps in our SDK as much as possible. |
|
Except in this case you didn't avoid anything, you literally cloned it. Pretty much every Express user out there will have this code duplicated. Oh well, thanks for the info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #9199
This PR vendors the
cookiemodule. I simplified the code a little since we don't use the options parameter.