Skip to content

feat: Remove tslib #9299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2023
Merged

feat: Remove tslib #9299

merged 1 commit into from
Oct 18, 2023

Conversation

AbhiPrasad
Copy link
Member

Inspired by #9199, let's try removing tslib.

Kept it with the angular package because I wasn't sure if angular build process needs it, but we can remove it if not needed.

@AbhiPrasad AbhiPrasad mentioned this pull request Oct 18, 2023
Closed
@AbhiPrasad AbhiPrasad marked this pull request as ready for review October 18, 2023 18:05
@AbhiPrasad
Copy link
Member Author

Did a sanity check + looked over built assets and seems to be fine.

timfish
timfish approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@timfish timfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) October 18, 2023 21:17
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 84 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.6 KB (0%)
@sentry/browser - Webpack (gzipped) 21.77 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 80.5 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 29.54 KB (-0.02% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 21.71 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 245.65 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 85.63 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 61.55 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 32.66 KB (-0.01% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 84.07 KB (0%)
@sentry/react - Webpack (gzipped) 21.81 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 102.21 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 49.67 KB (0%)

@AbhiPrasad AbhiPrasad merged commit 753f82b into develop Oct 18, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-remove-tslib branch October 18, 2023 22:44
@krystofwoldrich krystofwoldrich mentioned this pull request Feb 20, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timfish timfish timfish approved these changes

@lforst lforst lforst approved these changes

@mydea mydea Awaiting requested review from mydea

@Lms24 Lms24 Awaiting requested review from Lms24

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbhiPrasad @timfish @lforst