Skip to content

chore(astro): Add @sentry/astro package #9187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Oct 6, 2023

This PR adds the boilerplate files for the new @sentry/astro package. Amongst the usual files, some noteworthy things include:

  • Bumped the Volta Node version from 16 to 18 for the entire monorepo. I think this should be fine, given that this has no effect on the Node versions we test with in CI.
  • Using Vitest instead of Jest, like we do in SvelteKit. I think this is fine and should only lead to faster test execution times. It works well in SvelteKit
  • We don't know exactly yet how we're going to bundle the package so for now the rollup config is just a placeholder but things might still change here.

ref #9182

@Lms24 Lms24 requested review from HazAT, a team, stephanie-anderson, AbhiPrasad and mydea and removed request for a team and stephanie-anderson October 6, 2023 09:17
@Lms24 Lms24 mentioned this pull request Oct 6, 2023
@Lms24 Lms24 self-assigned this Oct 6, 2023
Copy link
Member

@HazAT HazAT Oct 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we already add the Astro keywords?
https://docs.astro.build/en/reference/publish-to-npm/#keywords

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially wanted to wait until we have something usable but then again, we'll iterate fast, so we can add it now, too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opted for a separate PR because I had to configure the package as public to get our e2e tests working. We can merge whenever we feel comfortable with actually publishing the package.
#9193

@Lms24 Lms24 merged commit 4236181 into develop Oct 6, 2023
@Lms24 Lms24 deleted the lms/astro-boilerplate-package branch October 6, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants