Skip to content

ref(node): Refactor node integrations to use processEvent #9018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 15, 2023
Merged

ref(node): Refactor node integrations to use processEvent #9018

merged 5 commits into from
Dec 15, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Sep 13, 2023 •
edited
Loading

This refactors Node integrations to use processEvent.

Missing is the LocalVariables integration, as that is more complicated and may need to be refactored in a different way to properly work.

@mydea mydea self-assigned this Sep 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 75.19 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 66.58 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 60.18 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.29 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 29.91 KB (0%)
@sentry/browser - Webpack (gzipped) 21.58 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 72.55 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 64.3 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 30.54 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 22.6 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 202.3 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 92.49 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 67.52 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 33.45 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 66.96 KB (0%)
@sentry/react - Webpack (gzipped) 21.62 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 83.7 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 48.4 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 16.19 KB (0%)

@mydea mydea force-pushed the fn/integration-processEvent branch from c2d603d to c354494 Compare September 14, 2023 14:42
Base automatically changed from fn/integration-processEvent to develop September 15, 2023 08:07
@mydea mydea force-pushed the fn/integrations-node branch 2 times, most recently from 0901c43 to f91a17e Compare September 21, 2023 07:26
@getsantry
Copy link

getsantry bot commented Oct 18, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 18, 2023
@mydea mydea removed the Stale label Oct 18, 2023
@mydea mydea force-pushed the fn/integrations-node branch from f91a17e to 9be8dfb Compare November 14, 2023 12:16
@mydea mydea marked this pull request as ready for review November 14, 2023 12:48
@mydea mydea requested a review from AbhiPrasad November 14, 2023 12:48
@mydea mydea force-pushed the fn/integrations-node branch 4 times, most recently from 90f5557 to d33ffc4 Compare December 13, 2023 15:12
@mydea mydea requested a review from AbhiPrasad December 13, 2023 15:12
@mydea
Copy link
Member Author

mydea commented Dec 13, 2023

rebased this on develop, had to change a few things...

@mydea mydea mentioned this pull request Dec 13, 2023
Closed
@timfish timfish mentioned this pull request Dec 13, 2023
Merged
@mydea mydea force-pushed the fn/integrations-node branch from d33ffc4 to e83426e Compare December 15, 2023 13:22
@mydea mydea merged commit 72c3488 into develop Dec 15, 2023
@mydea mydea deleted the fn/integrations-node branch December 15, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @AbhiPrasad