fix(remix): Guard against missing default export for server instrument #8909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Lms24
approved these changes
Aug 30, 2023
|
Hey @mydea , is it possible that this change is causing this error? I am using This pr seems to be something to do with default exports. |
|
Hey, this change only affects remix, so should not have any effect on nextjs. Could you open an issue with details of your setup & what error you are seeing? |
|
Thanks mate, for future Githubber I created this issue: #8934 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8904
I don't know enough about remix to know if/when this can actually happen, but doesn't hurt to guard anyhow!