-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(nextjs): Make all wrappers isomorphic and available in all runtimes #8743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a162d15
Rename files
lforst baa85a5
I expect this to completely implode
lforst 9271550
.
lforst 7f86b55
we have to keep the edge api handler :(
lforst cf0733f
fix lint
lforst f07c13c
Export n stuff
lforst 9420176
wrong export
lforst cfd278f
export middleware
lforst 4b26d21
Remove logic that should never ever happen
lforst 6a08aae
newlines
lforst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 0 additions & 20 deletions
20
packages/nextjs/src/client/wrapAppGetInitialPropsWithSentry.ts
This file was deleted.
Oops, something went wrong.
22 changes: 0 additions & 22 deletions
22
packages/nextjs/src/client/wrapDocumentGetInitialPropsWithSentry.ts
This file was deleted.
Oops, something went wrong.
23 changes: 0 additions & 23 deletions
23
packages/nextjs/src/client/wrapErrorGetInitialPropsWithSentry.ts
This file was deleted.
Oops, something went wrong.
20 changes: 0 additions & 20 deletions
20
packages/nextjs/src/client/wrapGetInitialPropsWithSentry.ts
This file was deleted.
Oops, something went wrong.
18 changes: 0 additions & 18 deletions
18
packages/nextjs/src/client/wrapGetServerSidePropsWithSentry.ts
This file was deleted.
Oops, something went wrong.
20 changes: 0 additions & 20 deletions
20
packages/nextjs/src/client/wrapGetStaticPropsWithSentry.ts
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
export { | ||
// eslint-disable-next-line deprecation/deprecation | ||
withSentryGetStaticProps, | ||
wrapGetStaticPropsWithSentry, | ||
} from './wrapGetStaticPropsWithSentry'; | ||
|
||
export { | ||
// eslint-disable-next-line deprecation/deprecation | ||
withSentryServerSideGetInitialProps, | ||
wrapGetInitialPropsWithSentry, | ||
} from './wrapGetInitialPropsWithSentry'; | ||
|
||
export { | ||
// eslint-disable-next-line deprecation/deprecation | ||
withSentryServerSideAppGetInitialProps, | ||
wrapAppGetInitialPropsWithSentry, | ||
} from './wrapAppGetInitialPropsWithSentry'; | ||
|
||
export { | ||
// eslint-disable-next-line deprecation/deprecation | ||
withSentryServerSideDocumentGetInitialProps, | ||
wrapDocumentGetInitialPropsWithSentry, | ||
} from './wrapDocumentGetInitialPropsWithSentry'; | ||
|
||
export { | ||
// eslint-disable-next-line deprecation/deprecation | ||
withSentryServerSideErrorGetInitialProps, | ||
wrapErrorGetInitialPropsWithSentry, | ||
} from './wrapErrorGetInitialPropsWithSentry'; | ||
|
||
export { | ||
// eslint-disable-next-line deprecation/deprecation | ||
withSentryGetServerSideProps, | ||
wrapGetServerSidePropsWithSentry, | ||
} from './wrapGetServerSidePropsWithSentry'; | ||
|
||
export { wrapServerComponentWithSentry } from './wrapServerComponentWithSentry'; | ||
|
||
export { wrapApiHandlerWithSentryVercelCrons } from './wrapApiHandlerWithSentryVercelCrons'; | ||
|
||
export { wrapMiddlewareWithSentry } from './wrapMiddlewareWithSentry'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 2 additions & 3 deletions
5
...nextjs/src/edge/utils/edgeWrapperUtils.ts → ...xtjs/src/common/utils/edgeWrapperUtils.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
9 changes: 7 additions & 2 deletions
9
...js/src/server/wrapApiHandlerWithSentry.ts → ...js/src/common/wrapApiHandlerWithSentry.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
...erver/wrapAppGetInitialPropsWithSentry.ts → ...ommon/wrapAppGetInitialPropsWithSentry.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
.../wrapDocumentGetInitialPropsWithSentry.ts → .../wrapDocumentGetInitialPropsWithSentry.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
...ver/wrapErrorGetInitialPropsWithSentry.ts → ...mon/wrapErrorGetInitialPropsWithSentry.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
...c/server/wrapGetInitialPropsWithSentry.ts → ...c/common/wrapGetInitialPropsWithSentry.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
...erver/wrapGetServerSidePropsWithSentry.ts → ...ommon/wrapGetServerSidePropsWithSentry.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
...rc/server/wrapGetStaticPropsWithSentry.ts → ...rc/common/wrapGetStaticPropsWithSentry.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...xtjs/src/edge/wrapMiddlewareWithSentry.ts → ...js/src/common/wrapMiddlewareWithSentry.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: newline consistency, but ignore it, as CI is already green