-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(nextjs): Make all wrappers isomorphic and available in all runtimes #8743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
kamilogorek
reviewed
Aug 8, 2023
@@ -0,0 +1,39 @@ | |||
export { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: newline consistency, but ignore it, as CI is already green
kamilogorek
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shuffling things around, what can possibly go wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8738
Fixes #8416
We had an issue that sometimes some exports from our SDK were not available in all of Next.js' runtimes. This caused an issue when people imported stuff from certain runtime files into other runtime files. (e.g. import something from
_app
inmiddleware
, which would cause an issue because the auto-injectedwrapAppGetInitialPropsWithSentry
is not exported from the edge part of the SDK).We are fixing this by exporting all of the auto-injected exports from everywhere. This is possible because theoretically all of these exports don't use any runtime-specific internals.