Skip to content

fix(replay): Cancel debounce when replay is too short/long #8742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Aug 7, 2023

Not sure if this has an impact, but it makes sense to cancel debounce anyhow in the case where we are too long/short.
When we are too short, we schedule a new flush anyhow.

@mydea mydea added Type: Bug Package: replay Issues related to the Sentry Replay SDK labels Aug 7, 2023
@mydea mydea requested a review from billyvg August 7, 2023 10:01
@mydea mydea self-assigned this Aug 7, 2023
@mydea mydea requested a review from Lms24 August 7, 2023 11:15
@mydea mydea merged commit 88e9418 into develop Aug 7, 2023
@mydea mydea deleted the fn/replay-duration branch August 7, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants